chore: Python pagination support #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwarishubham635
requested changes
Jan 19, 2026
| '{{{baseName}}}': {{#if vendorExtensions.x-serialize}}{{vendorExtensions.x-serialize}}({{paramName}}{{#if isArray}}, lambda e: e){{else}}){{/if}}{{else}}{{paramName}}{{/if}},{{/allParams}} | ||
| }){{/isApiV1}}{{^isApiV1}}{{#allParams}} | ||
| {{#startsWith paramName text='page_size'}}{{else}}{{paramName}}: Union[{{{dataType}}}, object] = values.unset,{{/startsWith}}{{/allParams}} | ||
| page_token: Union[str, object] = values.unset, |
Contributor
There was a problem hiding this comment.
Consider the case when page_token, page_size params are present in the spec file too, like this.
Contributor
Author
There was a problem hiding this comment.
these params are supported for token paginations. see the generated file https://github.com/twilio/twilio-python/pull/906/changes#diff-b0150af2b6d9e9ad8b9c685530aae36aeb5f35a0a6b67be43a92c02124bb6c2aR174-R177
| }){{/isApiV1}}{{^isApiV1}}{{#allParams}} | ||
| {{#startsWith paramName text='page_size'}}{{else}}{{paramName}}: Union[{{{dataType}}}, object] = values.unset,{{/startsWith}}{{/allParams}} | ||
| page_token: Union[str, object] = values.unset, | ||
| page_number: Union[int, object] = values.unset, |
Contributor
There was a problem hiding this comment.
In ApiV1, Page number is not present
Contributor
Author
There was a problem hiding this comment.
this case is for {{^isApiV1}} i.e existing functionality.
tiwarishubham635
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
A short description of what this PR does.
Checklist
make test-dockerpython scripts/build_twilio_library.py path/to/twilio-oai/spec/yaml path/to/twilio-java -l javaand inspect the diffmake testintwilio-javatwilio-javaIf you have questions, please create a GitHub Issue in this repository.